linux-kernel - Re: [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131030171257.0e3060ee@notabene.brown>
Date:	Wed, 30 Oct 2013 17:12:57 +1100
From:	NeilBrown <neilb@...e.de>
To:	Aurelien Jarno <aurelien@...el32.net>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h

On Tue, 29 Oct 2013 13:28:58 +0100 Aurelien Jarno <aurelien@...el32.net>
wrote:

> linux/raid/md_p.h is using conditionals depending on endianess and fails
> with an error if neither of __BIG_ENDIAN, __LITTLE_ENDIAN or
> __BYTE_ORDER are defined, but it doesn't include any header which can
> define these constants. This make this header unusable alone.
> 
> This patch adds a #include <asm/byteorder.h> at the beginning of this
> header to make it usable alone. This is needed to compile klibc on MIPS.
> 
> Signed-off-by: Aurelien Jarno <aurelien@...el32.net>
> ---
>  include/uapi/linux/raid/md_p.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/raid/md_p.h b/include/uapi/linux/raid/md_p.h
> index fe1a540..f7cf7f3 100644
> --- a/include/uapi/linux/raid/md_p.h
> +++ b/include/uapi/linux/raid/md_p.h
> @@ -16,6 +16,7 @@
>  #define _MD_P_H
>  
>  #include <linux/types.h>
> +#include <asm/byteorder.h>
>  
>  /*
>   * RAID superblock.

Makes sense.  Applied.  Thanks.

NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)