linux-kernel - Re: [PATCH 6/7] x86, asmlinkage, xen, kvm: Make {xen,kvm}_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131030092848.GD4651@redhat.com>
Date:	Wed, 30 Oct 2013 11:28:48 +0200
From:	Gleb Natapov <gleb@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>, konrad.wilk@...cle.com,
	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
Subject: Re: [PATCH 6/7] x86, asmlinkage, xen, kvm: Make
 {xen,kvm}_lock_spinning global and visible

On Tue, Oct 22, 2013 at 09:07:58AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> These functions are called from inline assembler stubs, thus
> need to be global and visible.
> 
> Cc: konrad.wilk@...cle.com
> Cc: gleb@...hat.com
> Cc: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
Acked-by: Gleb Natapov <gleb@...hat.com>

> ---
>  arch/x86/kernel/kvm.c   | 2 +-
>  arch/x86/xen/spinlock.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index a0e2a8a..5d10bb5 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -673,7 +673,7 @@ static cpumask_t waiting_cpus;
>  /* Track spinlock on which a cpu is waiting */
>  static DEFINE_PER_CPU(struct kvm_lock_waiting, klock_waiting);
>  
> -static void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
> +__visible void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
>  {
>  	struct kvm_lock_waiting *w;
>  	int cpu;
> diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
> index be6b860..3ab9309 100644
> --- a/arch/x86/xen/spinlock.c
> +++ b/arch/x86/xen/spinlock.c
> @@ -106,7 +106,7 @@ static DEFINE_PER_CPU(struct xen_lock_waiting, lock_waiting);
>  static cpumask_t waiting_cpus;
>  
>  static bool xen_pvspin = true;
> -static void xen_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
> +__visible void xen_lock_spinning(struct arch_spinlock *lock, __ticket_t want)
>  {
>  	int irq = __this_cpu_read(lock_kicker_irq);
>  	struct xen_lock_waiting *w = &__get_cpu_var(lock_waiting);
> -- 
> 1.8.3.1

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/