linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383131998.16560.106.camel@oc7383187364.ibm.com>
Date:	Wed, 30 Oct 2013 12:19:58 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	cody@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	utz.bacher@...ibm.com, mmarek@...e.cz, jsvogt@...ibm.com,
	MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com, michael@...ra.de,
	Frank Haverkamp <haver@...t.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3)

Hi Greg,

Am Freitag, den 25.10.2013, 16:21 +0100 schrieb Greg KH:
> On Fri, Oct 25, 2013 at 04:00:44PM +0200, Frank Haverkamp wrote:
> > > And why are you doing debug stuff through the ioctl interface?  Please
> > > move that to debugfs if you really want/need that information, it does
> > > not belong in an ioctl.
> > 
> > I will look into that. We need that information per card when it fails.
> 
> People put per-card information in debugfs all the time, look at the USB
> host controller files in debugfs for an example of how to do this.

Thanks for pointing me to the example. I moved some of my former sysfs
interfaces to debugfs. Especially those which were printing out more
than one item. I guess you don't like those in sysfs anyways.

> thanks,
> 
> greg k-h
> 

I re-posted our driver in "[PATCH] Generic WorkQueue Engine (GenWQE)
device driver (v4)" and addressed Ryans comments too.

Some of the module parameters I got rid of, some others I turned into
debugfs interfaces. Again others I replaced by constants with proven
default values. For those I kept, I added comments why I want them as
parameters still.

Regards

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/