linux-kernel - Re: [PATCH v3] dynamic_debug: add wildcard support to filter files/functions/modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABgQ-TjqiALfieAz8+6nt6TVxy93dJRv1UzkGMRMVO1CgfwXNg@mail.gmail.com>
Date:	Wed, 30 Oct 2013 21:57:44 +0800
From:	Changbin Du <changbin.du@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jason Baron <jbaron@...mai.com>,
	"linux-kernel@...r.kernel.org list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] dynamic_debug: add wildcard support to filter files/functions/modules

2013/10/30 Changbin Du <changbin.du@...il.com>:
> 2013/10/30 Joe Perches <joe@...ches.com>:
>> On Tue, 2013-10-29 at 21:33 +0800, Du, Changbin wrote:
>>> This patch add wildcard '*'(matches zero or more characters) and '?'
>>> (matches one character) support when qurying debug flags.
>>
>> Hi again.  Some trivial notes and a possible logic error:
>>
>> Maybe nicer with an if/else, I think you're still
>> missing a reset of "star = false;" and I also think
>> it's better to use a break here too.
>>
>>                 if (*s == *p) {
>>                         s++;
>>                         p++;
>>                         star = false;
>>                 } else {
>>                         if (!star)
>>                                 return false;
>>                         string++;
>>                         s = string;
>>                         p = pattern;
>>                 }
>>                 break;
>
> I have run loss of test before sending patch. all case passed. But I
> will double check if need reset star flag. really thanks!

Hi, Joe. I checked this. The "star = false;" can not have here.
Attachment is a test program that I use it to test the algorithm. it will
compare this non-recursion and old recursion if they are equal.

Now I will send the v3 patch, please help to review. Thanks!

View attachment "wildcard_alg.c" of type "text/x-csrc" (3230 bytes)