linux-kernel - Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52705967.1060603@asianux.com>
Date:	Wed, 30 Oct 2013 08:57:11 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	David Howells <dhowells@...hat.com>
CC:	Vineet Gupta <vineetg76@...il.com>,
	James Hogan <james.hogan@...tec.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	Max Filippov <jcmvbkbc@...il.com>
Subject: Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line
 character in the macro

On 10/29/2013 09:59 PM, David Howells wrote:
> Chen Gang <gang.chen@...anux.com> wrote:
> 
>>>>> For "kernel/modsign_certificate.S", I recommend to expand the macro
>>>>> which will shrink code line, either need not include additional header
>>>>> file, I feel that will be simpler for both code reader and writers.
>>> I recommend leaving that file alone.  That gets moved to a .S file in patches
>>> queued in the security tree.
>>
>> Excuse me, I am not quite familiar with our version merging, I guess
>> your meaning is "this file will be removed, and the related contents
>> will be in another .S file, so we need not fix it within this file".
>>
>> If what I guess is correct, I support your recommendation (and if what I
>> guess is incorrect, please let me know, thanks). :-)
> 
> Sorry, I misread what you were saying.  The code has already been split out of
> the .c file of course (I'd forgotten that it had).  In the security tree next
> branch, the .S file gets renamed and slightly modified here:
> 
> 	http://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git/commit/?h=next&id=b56e5a17b6b9acd16997960504b9940d0d7984e7
> 

Oh, thank you for your information, and I will send patch v3 for it.

I need/should based on another next-tree branch, and use its tag
"next-20131025" to continue (which already contents original related
changes).

And also, excuse me, my English is not quite well (which easily lead
other members misunderstanding).


Thanks.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/