linux-kernel - Re: [PATCH 11/12] sb_edac: avoid decoding the same error multiple times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <20131030152107.438876ea@samsung.com>
Date:	Wed, 30 Oct 2013 15:21:07 -0200
From:	Mauro Carvalho Chehab <m.chehab@...sung.com>
To:	Aristeu Rozanski <arozansk@...hat.com>
Cc:	linux-edac@...r.kernel.org, tony.luck@...el.com,
	Doug Thompson <dougthompson@...ssion.com> (supporter:EDAC-CORE),
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 11/12] sb_edac: avoid decoding the same error multiple times

Em Wed, 30 Oct 2013 12:27:05 -0400
Aristeu Rozanski <arozansk@...hat.com> escreveu:

> Whenever the extended error reporting is active, multiple MCEs will be
> generated for the same event, which will lead to multiple repeated
> errors to be reported. So check ADDRV and only decode the error if the
> MCE address is valid.
> 
> Signed-off-by: Aristeu Rozanski <arozansk@...hat.com>

For patches 2 to 11 on this series:

Reviewed-by: Mauro Carvalho Chehab <m.chehab@...sung.com>

> ---
>  drivers/edac/sb_edac.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 2e977b9..3c2f52b 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -1410,6 +1410,10 @@ static void sbridge_mce_output_error(struct mem_ctl_info *mci,
>  		}
>  	}
>  
> +	/* Only decode errors with an valid address (ADDRV) */
> +	if (!GET_BITFIELD(m->status, 58, 58))
> +		return;
> +
>  	rc = get_memory_error_data(mci, m->addr, &socket,
>  				   &channel_mask, &rank, &area_type, msg);
>  	if (rc < 0)


-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/