linux-kernel - Re: [PATCH] befs: fix return value check in befs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131030182902.GK20521@mwanda>
Date:	Wed, 30 Oct 2013 21:29:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Wei Yongjun <weiyj.lk@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	yongjun_wei@...ndmicro.com.cn, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] befs: fix return value check in befs_iget()

On Wed, Oct 30, 2013 at 10:52:38AM -0700, Kees Cook wrote:
> On Mon, Oct 28, 2013 at 7:00 PM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> > From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> >
> > In case of error, the function iget_locked() returns NULL pointer
> > not ERR_PTR(). The IS_ERR() test in the return value check should
> > be replaced with NULL test.
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Good catch, thanks!
> 
> Acked-by: Kees Cook <keescook@...omium.org>
> 
> As an aside, Dan, how hard would this kind of mismatch be to detect
> with smatch?

It already does, but you need the cross function database set up.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/