linux-kernel - Re: [PATCH 2/5] fat: add fat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9Dsj7P=WvnFuYqnMzO4+obXZzXODW4t-o8D6qgy28hdA@mail.gmail.com>
Date:	Wed, 30 Oct 2013 14:18:43 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, a.sahrawat@...sung.com,
	Namjae Jeon <namjae.jeon@...sung.com>
Subject: Re: [PATCH 2/5] fat: add fat_fallocate operation

2013/10/30, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>:
> Namjae Jeon <linkinjeon@...il.com> writes:
>
>>>> +	/* Release unwritten fallocated blocks on file release. */
>>>> +	if (round_up(inode->i_size, sb->s_blocksize) <
>>>> +	    MSDOS_I(inode)->i_disksize && inode->i_nlink != 0)
>>>> +		fat_truncate_blocks(inode, inode->i_size);
>>>> +
>>>>  	truncate_inode_pages(&inode->i_data, 0);
>>>>  	if (!inode->i_nlink) {
>>>>  		inode->i_size = 0;
>
> [...]
>
>>> And inode->i_size should be ->mmu_private?
>> Sorry, I don't understand your question yet...
>> Could you elaborate more ?
>
> "if" part is checking "round_up(->i_size) < ->i_disksize", but I guess
> fallocate() truncation should be only needed if there is uninitialized
> data. So, I felt that part should check ->mmu_private and ->i_disksize.
Yes, right. I will change it as your points.
Thanks for review!!

>
> Thanks.
> --
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/