linux-kernel - Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52720CA4.3090003@gmail.com>
Date:	Thu, 31 Oct 2013 08:54:12 +0100
From:	Philippe Rétornaz <philippe.retornaz@...il.com>
To:	Nicolin Chen <b42378@...escale.com>
CC:	s.hauer@...gutronix.de, timur@...i.org, shawn.guo@...aro.org,
	broonie@...nel.org, mark.rutland@....com,
	devicetree@...r.kernel.org, alsa-devel@...a-project.org,
	pawel.moll@....com, linux-doc@...r.kernel.org,
	swarren@...dotorg.org, linux-kernel@...r.kernel.org,
	rob.herring@...xeda.com, galak@...eaurora.org,
	dmaengine@...r.kernel.org, ijc+devicetree@...lion.org.uk,
	linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support

Hi

>
> +			/* When using dual fifo mode, we need to keep watermark
> +			 * as even numbers due to dma script limitation.
> +			 */
> +			ssi_private->dma_params_tx.maxburst /= 2;
> +			ssi_private->dma_params_tx.maxburst *= 2;
> +			ssi_private->dma_params_rx.maxburst /= 2;
> +			ssi_private->dma_params_rx.maxburst *= 2;
>

Why not using a mask here ?
ssi_private->dma_params_tx.maxburst &= ~0x1;
ssi_private->dma_params_rx.maxburst &= ~0x1;

Regards,

Philippe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/