lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Oct 2013 12:28:49 +0000 From: Chen Guangyu-B42378 <B42378@...escale.com> To: Timur Tabi <timur@...i.org> CC: "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "shawn.guo@...aro.org" <shawn.guo@...aro.org>, "broonie@...nel.org" <broonie@...nel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "rob.herring@...xeda.com" <rob.herring@...xeda.com>, "mark.rutland@....com" <mark.rutland@....com>, "swarren@...dotorg.org" <swarren@...dotorg.org>, "pawel.moll@....com" <pawel.moll@....com>, "ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>, "galak@...eaurora.org" <galak@...eaurora.org>, "philippe.retornaz@...il.com" <philippe.retornaz@...il.com> Subject: Re: [PATCH v3 3/4] ASoC: fsl_ssi: Add dual fifo mode support Thank you for the comments. I'll refine this part. Sent by Android device. Timur Tabi <timur@...i.org> wrote: Nicolin Chen wrote: > + if (ssi_private->use_dual_fifo) { > + write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1); > + write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1); > + write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN); > + } else { > + write_ssi_mask(&ssi->srcr, CCSR_SSI_SRCR_RFEN1, 0); > + write_ssi_mask(&ssi->stcr, CCSR_SSI_STCR_TFEN1, 0); > + write_ssi_mask(&ssi->scr, CCSR_SSI_SCR_TCH_EN, 0); > + } Why do you need the "else" part? Why can't you just do this: if (ssi_private->use_dual_fifo) { write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1); write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1); write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists