linux-kernel - Re: [PATCH V2] printk/cache: Mark printk_once test variable __read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Oct 2013 13:35:49 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Joe Perches <joe@...ches.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
	<linux-metag@...r.kernel.org>
Subject: Re: [PATCH V2] printk/cache: Mark printk_once test variable __read_mostly

On 30/10/13 23:01, Joe Perches wrote:
> Add #include <linux/cache.h> to define __read_mostly.
> 
> Convert cache.h to use uapi/linux/kernel.h instead
> of linux/kernel.h to avoid recursive #includes.
> 
> Convert the ALIGN macro to __KERNEL_ALIGN.
> 
> printk_once only sets the bool variable tested
> once so mark it __read_mostly.
> 
> Neaten the alignment so it matches the rest of the
> pr_<level>_once #defines too.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> V2: Add cache.h which was nearly always used
>     indirectly via #include <some_other_file.h>,
>     generally module.h
>     Update cache.h to avoid recursive #include
> 
>  include/linux/cache.h  |  4 ++--
>  include/linux/printk.h | 19 ++++++++++---------
>  2 files changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/include/linux/cache.h b/include/linux/cache.h
> index 4c57065..63a1d97 100644
> --- a/include/linux/cache.h
> +++ b/include/linux/cache.h
> @@ -1,11 +1,11 @@
>  #ifndef __LINUX_CACHE_H
>  #define __LINUX_CACHE_H
>  
> -#include <linux/kernel.h>
> +#include <uapi/linux/kernel.h>
>  #include <asm/cache.h>
>  
>  #ifndef L1_CACHE_ALIGN
> -#define L1_CACHE_ALIGN(x) ALIGN(x, L1_CACHE_BYTES)
> +#define L1_CACHE_ALIGN(x) __KERNEL_ALIGN(x, L1_CACHE_BYTES)

I think that should be __ALIGN_KERNEL (same applies to commit message).

Otherwise this patch looks good to me and builds all Meta defconfigs fine.
Reviewed-by: James Hogan <james.hogan@...tec.com>

Thanks
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/