[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20131031141619.GG10091@kernel.dk>
Date: Thu, 31 Oct 2013 08:16:19 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Wei Yongjun <weiyj.lk@...il.com>
Cc: rchinthekindi@...c-inc.com, abhansali@...c-inc.com,
jmoyer@...hat.com, ramprasad.chinthekindi@...t.com,
yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] skd: fix error return code in skd_pci_probe()
On Wed, Oct 30 2013, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fix to return -ENOMEM in the skd construct error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
> drivers/block/skd_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index ab17bff..1a8717f 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -5321,8 +5321,10 @@ static int skd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> }
>
> skdev = skd_construct(pdev);
> - if (skdev == NULL)
> + if (skdev == NULL) {
> + rc = -ENOMEM;
> goto err_out_regions;
> + }
>
> skd_pci_info(skdev, pci_str);
> pr_info("(%s): %s 64bit\n", skd_name(skdev), pci_str);
Applied, thanks.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists