linux-kernel - Re: WTF: driver-core-next contains recursive directory removal!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131031152950.GC11698@mtj.dyndns.org>
Date:	Thu, 31 Oct 2013 11:29:50 -0400
From:	Tejun Heo <tj@...nel.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: WTF: driver-core-next contains recursive directory removal!

Hello, Eric.

On Wed, Oct 30, 2013 at 06:19:27PM -0700, Eric W. Biederman wrote:
> The biggest and worst issue is the semantics are total unmaintable
> garbage and there has never been a single counter argument to that.
> 
> Recursive delete is WRONG.
> 
> Further there was no follow up converstion on the list about this trash
> to say you had tested it.  Or anything else.

I think you're going over the line.  You were cc'd on all patches and
all the counter points that I wrote in this thread are repetitions
from the previous threads.  I don't remember you answering to any of
the counter points.

> Even the partial recursive delete we currently have has been responsible
> for broken users of sysfs so I don't see how adding additional checks is
> going to do anything but paper over real bugs in real uses of sysfs.

Can you please go into details of what kind of bugs would be
introduced by recursive removal?  I'd really like to know and be happy
to fix any actual issues but you really aren't providing useful enough
information.

> Will you please remove that garbage from your tree. 

Eric, chill.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/