linux-kernel - Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131031155602.GP1935@sgi.com>
Date:	Thu, 31 Oct 2013 10:56:03 -0500
From:	Ben Myers <bpm@....com>
To:	Denis Efremov <yefremov.denis@...il.com>
Cc:	ldv-project@...uxtesting.org, Alex Elder <elder@...nel.org>,
	linux-kernel@...r.kernel.org, xfs@....sgi.com
Subject: Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for
 null

On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote:
> On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> > ASSERT on args takes place after args dereference.
> > This assertion is redundant since we are going to panic anyway.
> > 
> > Found by Linux Driver Verification project (linuxtesting.org) -
> > PVS-Studio analyzer.
> > 
> > Signed-off-by: Denis Efremov <yefremov.denis@...il.com>
> 
> Looks good. 
> 
> Reviewed-by: Ben Myers <bpm@....com>

Applied.  Thanks Denis.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/