linux-kernel - Re: [PATCH] recordmcount.pl: add support for __fentry_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131031120926.112c3c26@gandalf.local.home>
Date:	Thu, 31 Oct 2013 12:09:26 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jamie Iles <jamie.iles@...cle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] recordmcount.pl: add support for __fentry__

On Thu, 31 Oct 2013 15:59:58 +0000
Jamie Iles <jamie.iles@...cle.com> wrote:

> With gcc 4.6.0 the -mfentry feature places the function profiling call
> at the start of the function. When this is used, the call is to
> __fentry__ and not mcount.
> 
> Based on 48bb5dc6cd9d30fe0d594947563da1f8bd9abada (ftrace: Make
> recordmcount.c handle __fentry__).

Why? All current users of __fentry__ use the C version of recordmcount.
This just slows down the few archs that still use recordmcount.pl.

-- Steve

> 
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Jamie Iles <jamie.iles@...cle.com>
> ---
>  scripts/recordmcount.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index a674fd5..6460fc68 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -214,7 +214,7 @@ $local_regex = "^[0-9a-fA-F]+\\s+t\\s+(\\S+)";
>  $weak_regex = "^[0-9a-fA-F]+\\s+([wW])\\s+(\\S+)";
>  $section_regex = "Disassembly of section\\s+(\\S+):";
>  $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:";
> -$mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount\$";
> +$mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\s(mcount|__fentry__)\$";
>  $section_type = '@...gbits';
>  $mcount_adjust = 0;
>  $type = ".long";

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/