linux-kernel - Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131031141056.1525429a@notabene.brown>
Date:	Thu, 31 Oct 2013 14:10:56 +1100
From:	NeilBrown <neilb@...e.de>
To:	majianpeng <majianpeng@...il.com>
Cc:	axboe <axboe@...nel.dk>, LKML <linux-kernel@...r.kernel.org>,
	linux-raid <linux-raid@...r.kernel.org>
Subject: Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we
 replace REQ_FLUSH with REQ_NOMERGE.

On Wed, 30 Oct 2013 10:41:46 +0800 majianpeng <majianpeng@...il.com> wrote:

> For R5_ReadNoMerge,it mean this bio can't merge with other bios or
> request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the
> same work.
> 
> Signed-off-by: Jianpeng Ma <majianpeng@...il.com>
> ---
>  drivers/md/raid5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index f8b9068..8e0aeaa 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -772,7 +772,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
>  				bi->bi_sector = (sh->sector
>  						 + rdev->data_offset);
>  			if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
> -				bi->bi_rw |= REQ_FLUSH;
> +				bi->bi_rw |= REQ_NOMERGE;
>  
>  			bi->bi_vcnt = 1;
>  			bi->bi_io_vec[0].bv_len = STRIPE_SIZE;

Thanks.

I've queued this up pending Jens' acceptance of the other patches.

By the way, your patch file has a carriage return as well as a newline at the
end of each line.
"patch" can still handle them but "git am" doesn't like it.

If you are able to send the patches as plain text with just a NEWLINE at the
end of each line, rather than base64 encodes with carriage returns, it would
help a little.

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)