[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20131031142619.d7aed35fe536f5a177012d27@linux-foundation.org>
Date: Thu, 31 Oct 2013 14:26:19 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Nicolin Chen <b42378@...escale.com>
Cc: <joe@...ches.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RESEND] lib/genalloc: add a helper function for DMA
buffer allocation
On Thu, 31 Oct 2013 17:16:07 +0800 Nicolin Chen <b42378@...escale.com> wrote:
> When using pool space for DMA buffer, there might be duplicated calling
> of gen_pool_alloc() and gen_pool_virt_to_phys() in each implementation.
>
> Thus it's better to add a simple helper function, a compatible one to
> the common dma_alloc_coherent(), to save some code.
>
Well OK, but this new function doesn't have any callers. So it
increases kernel size and is untestable.
Do you have any conversion patches which we can merge to address these
problems?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists