linux-kernel - Re: [PATCH V2] checkpatch: Improve "return is not a function" test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Oct 2013 18:03:35 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	Joe Perches <joe@...ches.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] checkpatch: Improve "return is not a function" test

On 10/31/2013 04:12 PM, Joe Perches wrote:
> Find a few more cases where parentheses are used around
> the value of a return statement.
> 
> This now uses the "$balanced_parens" test and also makes
> the test depend on perl v5.10 and higher.
> 
> This now finds return with parenthesis uses the old code
> did not find like:
> 
> ERROR: return is not a function, parentheses are not required
> #211: FILE: arch/m68k/include/asm/sun3xflop.h:211:
> +		return ((error == 0) ? 0 : -1);
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

It catches the previous false-negative I had.

Acked-by: David Cohen <david.a.cohen@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/