linux-kernel - Re: [PATCH -tip] fix race between stop_two_cpus and stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Nov 2013 08:08:00 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	Rik van Riel <riel@...hat.com>
CC:	Mel Gorman <mgorman@...e.de>, peterz@...radead.org,
	mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] fix race between stop_two_cpus and stop_cpus



On 11/01/2013 07:36 AM, Rik van Riel wrote:
> On 11/01/2013 07:08 AM, Mel Gorman wrote:
>> On Thu, Oct 31, 2013 at 04:31:44PM -0400, Rik van Riel wrote:
>>> There is a race between stop_two_cpus, and the global stop_cpus.
>>>
>>
>> What was the trigger for this? I want to see what was missing from my own
>> testing. I'm going to go out on a limb and guess that CPU hotplug was also
>> running in the background to specifically stress this sort of rare condition.
>> Something like running a standard test with the monitors/watch-cpuoffline.sh
>> from mmtests running in parallel.
> 
> AFAIK the trigger was a test that continuously loads and
> unloads kernel modules, while doing other stuff.
>

With this patch in place the module load/unload test ran for ~16 hours without
failure.  Without the patch the test usually fails in 5-10 minutes.

Tested-by: Prarit Bhargava <prarit@...hat.com>

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/