linux-kernel - Re: [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5273AEE2.2010005@cogentembedded.com>
Date:	Fri, 01 Nov 2013 17:38:42 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>, acme@...stprotocols.net
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

Hello.

On 01-11-2013 14:00, Duan Jiong wrote:

> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.

> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
> ---
>   drivers/net/appletalk/ipddp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

> diff --git a/drivers/net/appletalk/ipddp.c b/drivers/net/appletalk/ipddp.c
> index 10d0dba..78f06cb 100644
> --- a/drivers/net/appletalk/ipddp.c
> +++ b/drivers/net/appletalk/ipddp.c
> @@ -312,9 +312,7 @@ module_param(ipddp_mode, int, 0);
>   static int __init ipddp_init_module(void)
>   {
>   	dev_ipddp = ipddp_init();
> -        if (IS_ERR(dev_ipddp))
> -                return PTR_ERR(dev_ipddp);
> -	return 0;
> +        return PTR_ERR_OR_ZERO(dev_ipddp);

    Indent with a tab, please.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/