linux-kernel - Re: linux-next: Tree for Oct 31 (crypto, rsa, mpi)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5273F142.3090608@infradead.org>
Date:	Fri, 01 Nov 2013 11:21:54 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	David Howells <dhowells@...hat.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org
Subject: Re: linux-next: Tree for Oct 31 (crypto, rsa, mpi)

On 11/01/13 08:16, David Howells wrote:
> Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> crypto/built-in.o: In function `RSA_verify_signature':
>> rsa.c:(.text+0x1d347): undefined reference to `mpi_get_nbits'
>> rsa.c:(.text+0x1d354): undefined reference to `mpi_get_nbits'
>> ...
> 
> Does the attached patch fix it for you?

Yes, thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>


> 
> David
> ---
> KEYS: The RSA public key algorithm needs to select MPILIB
> 
> The RSA public key algorithm needs to select MPILIB directly in Kconfig as the
> 'select' directive is not recursive and is thus MPILIB is not enabled by
> selecting MPILIB_EXTRA.
> 
> Without this, the following errors can occur:
> 
> 	crypto/built-in.o: In function `RSA_verify_signature':
> 	rsa.c:(.text+0x1d347): undefined reference to `mpi_get_nbits'
> 	rsa.c:(.text+0x1d354): undefined reference to `mpi_get_nbits'
> 	rsa.c:(.text+0x1d36e): undefined reference to `mpi_cmp_ui'
> 	rsa.c:(.text+0x1d382): undefined reference to `mpi_cmp'
> 	rsa.c:(.text+0x1d391): undefined reference to `mpi_alloc'
> 	rsa.c:(.text+0x1d3b0): undefined reference to `mpi_powm'
> 	rsa.c:(.text+0x1d3c3): undefined reference to `mpi_free'
> 	rsa.c:(.text+0x1d3d8): undefined reference to `mpi_get_buffer'
> 	rsa.c:(.text+0x1d4d4): undefined reference to `mpi_free'
> 	rsa.c:(.text+0x1d503): undefined reference to `mpi_get_nbits'
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> index 82e7d6b0c276..03a6eb95ab50 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -23,6 +23,7 @@ config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
>  config PUBLIC_KEY_ALGO_RSA
>  	tristate "RSA public-key algorithm"
>  	select MPILIB_EXTRA
> +	select MPILIB
>  	help
>  	  This option enables support for the RSA algorithm (PKCS#1, RFC3447).
>  
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/