linux-kernel - Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131101.180147.629210014672277622.davem@davemloft.net>
Date:	Fri, 01 Nov 2013 18:01:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	mchan@...adcom.com, tdmackey@...leanhaiku.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu, 31 Oct 2013 21:19:16 -0700

> 2013年10月30日 下午9:26于 "David Miller" <davem@...emloft.net>写道：
>>
>> We have to provide a softint compatible environment for this callback
>> to run in else everything is completely broken.
>>
>> All these drivers can safely assume softirq safe locking is
>> sufficient, you're suggesting we need to take this hardirq safety and
>> I'm really not willing to allow things to go that far.  A lot of
>> effort has been expended precisely to avoid that kind of overhead and
>> cost.
> 
> Alright, I am thinking to move netpoll_poll_dev() to a delayed work.
 
What if the printk is outputting a message that will help us discover
that work queues are deadlocked?

You can't delay the message, because every layer of indirection you
add increases the possibility that the message it never seen.  You
have to do it synchronously.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/