lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Nov 2013 15:07:17 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Stanislav Fomichev <stfomichev@...dex-team.ru> Cc: a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com, acme@...stprotocols.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/6] perf timechart: use proc_num to implement --power-only On Tue, 29 Oct 2013 13:28:46 +0400, Stanislav Fomichev wrote: >> I don't see how it does same thing. You mean it by skipping >> draw_process_bars() and draw_wakeups() on patch 1? It'd be better >> changelog explains the details. > Yes, it depends on the previous patch, I'll add more info to the > changelog. If so, I think it'd better moving the if () parts into this patch. Thanks, Namhyung > >> And I'd like to keep it as BOOLEAN option - it's simpler and more >> straight-forward IMHO. >> >> How about adding >> >> if (power_only) >> proc_num = 0; >> >> after parsing the command line options? > Ok, this works too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists