lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 2 Nov 2013 16:27:45 +0000
From:	Al Viro <>
To:	Greg KH <>
Cc:	Chen Gang <>,
	Kees Cook <>,
	"Eric W. Biederman" <>,
	Serge Hallyn <>,
	"" <>
Subject: Re: [PATCH] fs/befs/linuxvfs.c: need signed cast for variable 'block'

On Sat, Nov 02, 2013 at 08:44:46AM -0700, Greg KH wrote:

> > Oh, for me, it is not suitable to move a file system sub-directory to
> > "drivers/*/" sub-directory. And I can not find any sub-directory like
> > 'staging' under "fs" sub-directory, either.
> > 
> > Do we have any sub-directory like "staging" in "fs" sub-directory? if
> > no, do we have to create it or have to use another ways instead of?
> Just move the filesystem to drivers/staging/befs.

Actually, having read through that code...  It's not too scary; r/w
support would've been much more hairy, but this is just r/o.  We
probably don't need to move that sucker at all.

As for befs_get_block(), I'd suggest
	* taking the range checks for block number into its ->bmap()
(just check against the file size and return 0 if it doesn't fit)
	* turning the check for create != 0 into BUG_ON(create)
	* making the befs_fblock2brun() failure quiet - the sucker
will complain itself, just return that -EFBIG and be done with that.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists