linux-kernel - Re: [PATCH 2/3] watchdog: at91sam9_wdt: avoid spurious watchdog reset during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5276914C.3010803@roeck-us.net>
Date:	Sun, 03 Nov 2013 10:09:16 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Boris BREZILLON <b.brezillon@...rkiz.com>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	Fabio Porcedda <fabio.porcedda@...il.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Guenter Roeck <groeck7@...il.com>,
	Yang Wenyou <wenyou.yang@...el.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 2/3] watchdog: at91sam9_wdt: avoid spurious watchdog reset
 during init

On 11/03/2013 09:52 AM, Boris BREZILLON wrote:
> Use the min_heartbeat value instead of the calculated heartbeat value for
> the first watchdog reset to avoid spurious watchdog reset.
>
> Resetting the watchdog counter during init might lead to a watchdog fault
> reset because the watchdog counter has to be running for at least
> min_heartbeat.
>
> Resetting the watchdog counter after heartbeat might lead to a watchdog
> timeout reset because the watchdog counter is running for more than
> max_heartbeat time.
>
> Using min_heartbeat instead of heartbeat does not guarantee that the
> watchdog won't trigger a reset, but at least it reduces the chances to be
> in such a case.
>
> Signed-off-by: Boris BREZILLON <b.brezillon@...rkiz.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/