linux-kernel - Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5276CBAE.8010301@redhat.com>
Date:	Sun, 03 Nov 2013 23:18:22 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Jason Wang <jasowang@...hat.com>
CC:	davem@...emloft.net, edumazet@...gle.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Petr Matousek <pmatouse@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

On 11/01/2013 08:01 AM, Jason Wang wrote:
> We don't validate iph->ihl which may lead a dead loop if we meet a IPIP
> skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl
> is evil (less than 5).
>
> This issue were introduced by commit ec5efe7946280d1e84603389a1030ccec0a767ae
> (rps: support IPIP encapsulation).
>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Petr Matousek <pmatouse@...hat.com>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: Daniel Borkmann <dborkman@...hat.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Sorry, a bit late as I was offline last 4 days, but fwiw:

Acked-by: Daniel Borkmann <dborkman@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/