linux-kernel - Re: [PATCH] pinctrl: remove minor dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaoVR+Fkt2bX65KCQxSDvKNy_BoGNB=dNW9uzfT2GSE-Q@mail.gmail.com>
Date:	Mon, 4 Nov 2013 13:07:31 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: remove minor dead code

On Tue, Oct 29, 2013 at 4:50 AM, Michael Opdenacker
<michael.opdenacker@...e-electrons.com> wrote:

> This removes a test whether the 'desc' variable is NULL.
> This possibility has already been eliminated by the
> below test earlier in the loop:
>
>                 if (desc == NULL) {
>                         dev_warn(pctldev->dev,
>                                  "could not get pin desc for pin %d\n",
>                                  pins[i]);
>                         continue;
>                 }
>
> Found with Coverity: CID #1090078
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>

Pretty cool find!

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/