linux-kernel - Re: [PATCH v2] debugobject: add support for kref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131104161548.GA26097@breakpoint.cc>
Date:	Mon, 4 Nov 2013 17:15:48 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...akpoint.cc>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	jic23@...nel.org, lars@...afoo.de, gregkh@...uxfoundation.org
Subject: Re: [PATCH v2] debugobject: add support for kref

On 03.11.13, Sebastian Andrzej Siewior wrote:
> v1…v2:
> - not an RFC anymore
> - addressed tglx review:
>   - use debug_obj_descr with state active
>   - use debug_object_active_state() to check for active object instead the
>     other hack I had.
>   - added debug_object_free() in a way that does not interfere with the
>     NSA sniffer API so it does not get removed from the patch by accident.

now I just run into output like
|ODEBUG: free active (active state 0) object type: kref hint: gserial_alloc_line+0x90/0x194 [u_serial]

and yes I added a hint for that which points to where the kref got it
kref_init() call from. Now I am not sure if this a false positive
(we did kref_init() never used it so the whole struct was removed) or if
it really found something.
And while I hit this, I noticed that I really need a fixup function or
else debugobject will loop forever in __debug_check_no_obj_freed().

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/