linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383582634.15642.18.camel@oc7383187364.ibm.com>
Date:	Mon, 04 Nov 2013 17:30:34 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	cody@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	utz.bacher@...ibm.com, mmarek@...e.cz, rmallon@...il.com,
	jsvogt@...ibm.com, MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com,
	michael@...ra.de, Frank Haverkamp <haver@...t.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

Hi Greg,

Am Mittwoch, den 30.10.2013, 10:37 -0700 schrieb Greg KH:
> On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
> > +/*
> > + * We like to be able to disable the health checking entirely in some
> > + * cases e.g. if a card is broken and needs to be analyzed. I
> > + * considered using debugfs/sysfs attributes, but I did not see a way
> > + * to prevent the thread from being started at driver load time other
> > + * than starting it later manually, what I did not like either
> > + * in this case (e.g. like the new SRIOV enablement).
> > + */
> > +static int genwqe_health_check_interval = 4;   /* <= 0: disabled */
> > +module_param(genwqe_health_check_interval, int, 0644);  /* read/writeable */
> > +MODULE_PARM_DESC(genwqe_health_check_interval,
> > +		 "check card health every N seconds (0 = disabled)");
> 
> Module paramaters are driver wide, not device specific.
> 
> If a card is broken, it's broken, send it back.  No one will ever know
> to set this value, and then you just affected all other cards in the
> system for this same driver.
> 
> Just delete this please.
> 
> thanks,
> 
> greg k-h
> 

Finally I removed all my module parameters or replaced them by debugfs
or sysfs attributes.

Regards

Frank



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/