linux-kernel - Re: [PATCH 3/3] perf tools: Check maximum frequency rate for record/top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131104175613.GA20505@infradead.org>
Date:	Mon, 4 Nov 2013 15:56:13 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	David Ahern <dsahern@...il.com>, linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 3/3] perf tools: Check maximum frequency rate for
 record/top

Em Mon, Nov 04, 2013 at 04:32:16PM +0100, Jiri Olsa escreveu:
> On Mon, Nov 04, 2013 at 08:17:24AM -0700, David Ahern wrote:
> > On 11/4/13, 4:06 AM, Jiri Olsa wrote:
> > >Adding the check for maximum allowed frequency rate
> > >defined in following file:
> > >   /proc/sys/kernel/perf_event_max_sample_rate
> > >
> > >When we cross the maximum value we fail and display
> > >detailed error message with advise.
> > 
> > perf commands should automatically adjust the default frequency too.
> > If the user did not specify a frequency then this message is going
> > to be confusing.
> 
> ok, I'll add that check and probably some warning
> if we are force to go below the default rate.

I think we should just make it clear the frequency used and pick the
best according to the hardware.

And we are not doing gthat at all, at least in the TUI, need to change
that.

Only in the stdio, with that long list of commented lines, that should
as well be hidden, too verbose.

And here we also see the frequency used:

[root@zoo linux]# perf evlist -v
cycles: sample_freq=4000, size: 96, sample_type: IP|TID|TIME|PERIOD,
disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, enable_on_exec: 1,
sample_id_all: 1, exclude_guest: 1
[root@zoo linux]#
 
 > 
> > Though the algorithm that keeps lowering the rate should be tweaked as well.
> 
> yea.. I was thinking putting the max rate back up after
> some sane period
> 
> or/plus having 'echo 0 > /proc/sys/kernel/perf_event_max_sample_rate' to
> disable it completely
> 
> jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/