lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 04 Nov 2013 14:24:07 -0800 From: Joe Perches <joe@...ches.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Andy Whitcroft <apw@...dowen.org>, David Cohen <david.a.cohen@...ux.intel.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH V2] checkpatch: Improve "return is not a function" test On Mon, 2013-11-04 at 14:21 -0800, Andrew Morton wrote: > On Thu, 31 Oct 2013 16:12:44 -0700 Joe Perches <joe@...ches.com> wrote: > > > This now uses the "$balanced_parens" test and also makes > > the test depend on perl v5.10 and higher. > > What happens if one uses an older perl version? A mysterious-looking > splat, I assume? > > It would be nicer to have some explicit perl version test which tells > user what the problem is, and which perl version is needed? > There is such a test already. You Signed-off on it. commit d62a201f24cba74e2fbf9f6f7af86ff5f5e276fc Author: Dave Hansen <dave.hansen@...ux.intel.com> Date: Wed Sep 11 14:23:56 2013 -0700 checkpatch: enforce sane perl version I got a bug report from a couple of users who said checkpatch.pl was broken for them. It was erroring out on fairly random lines most commonly with messages like: Nested quantifiers in regex; marked by <--HERE in m/(\((?:[^\(\)]++ <- The bug reporter was running a version of perl 5.8 which was end-of-lifed in 2008: http://www.cpan.org/src/. Versions of perl this old are at _best_ quite untested. At worst, they are crusty and known to be completely broken. If folks have a system _that_ old, then we should have mercy on them and give them a half-decent error message rather than fail with nutty error messages. This patch enforces that checkpatch.pl is run with perl 5.10, which was end-of-lifed in 2009. The new --ignore-perl-version command-line switch will let folks override this if they want. Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com> Cc: Joe Perches <joe@...ches.com> Cc: Andy Whitcroft <apw@...dowen.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists