linux-kernel - Re: [PATCH 2/9] GenWQE: Remove option to select name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1383642001.15859.1.camel@oc7383187364.ibm.com>
Date:	Tue, 05 Nov 2013 10:00:01 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Ryan Mallon <rmallon@...il.com>
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	gregkh@...uxfoundation.org, cody@...ux.vnet.ibm.com,
	schwidefsky@...ibm.com, utz.bacher@...ibm.com, mmarek@...e.cz,
	jsvogt@...ibm.com, MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com,
	michael@...ra.de
Subject: Re: [PATCH 2/9] GenWQE: Remove option to select name

Hi Ryan,

Am Dienstag, den 05.11.2013, 08:55 +1100 schrieb Ryan Mallon:
> On 05/11/13 04:08, Frank Haverkamp wrote:
> > Selecting interface names via configuration option is obsolete.
> 
> Don't do this. You are adding completely new code, so there is no reason
> to post a patch full of code that is known to be incorrect, followed by
> a set of patches fixing things. Just post the correct code to start
> with. This makes the git history cleaner, and makes the code easier to
> review.

Agreed.

> You can use tools like git interactive rebase to split your work into
> multiple patches. It should be quite easy for this because you mostly
> just want to break down things to the file level, so even:
> 
>   git reset --soft <your-first-commit>
> 
> and then manually staging and commiting things from there would probably
> be enough. You can use git add --interactive to stage individual file
> hunks if you want to break things down further.

I have sent "Generic WorkQueue Engine (GenWQE) device driver (v6)" now
which hopefully is what you wanted.

Regards

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/