linux-kernel - RE: mei: cancel stall timers in mei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C980C034A53E0646B96866D6CE3D187A3330D460@HASMSX106.ger.corp.intel.com>
Date:	Tue, 5 Nov 2013 09:58:25 +0000
From:	"Usyskin, Alexander" <alexander.usyskin@...el.com>
To:	Eugene Shatokhin <eugene.shatokhin@...alab.ru>
CC:	Nicolò Costanza <abitrules@...oo.it>,
	Alex Burmashev <alex.burmashev@...alab.ru>,
	LKML <linux-kernel@...r.kernel.org>,
	"Winkler, Tomas" <tomas.winkler@...el.com>
Subject: RE: mei: cancel stall timers in mei_reset

Hi

The problem that you found was fixed in patch here: https://lkml.org/lkml/2013/6/23/169
And this patch merged into 3.11 according to http://lxr.free-electrons.com/source/drivers/misc/mei/mei_dev.h?v=3.11
Can you re-check with latest 3.11 point release?


Thanks
--
Sasha

-----Original Message-----
From: Eugene Shatokhin [mailto:eugene.shatokhin@...alab.ru] 
Sent: Tuesday, November 05, 2013 10:07
To: Winkler, Tomas
Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML
Subject: Re: mei: cancel stall timers in mei_reset

On 11/04/2013 07:48 PM, Eugene Shatokhin wrote:
> ----- Original Message -----
>> I would appreciate the full log and your .config
>
> I have attached the config and the log.
>
> Meanwhile, I have found one suspicious place in the code that could be related: mei_reset() ignores the return value of mei_hw_start(). According to the logs, there was at least the following interesting call sequence before things went wrong:
>
> mei_reset() => mei_hw_start() => .hw_start() callback, which is mei_me_hw_start() => mei_me_hw_ready_wait().
>
> mei_me_hw_ready_wait() reported "wait hw ready failed" and returned -ETIMEDOUT, that error was propagated to mei_hw_start(). mei_reset(), however, does not check the return value of that function and goes on even if it returns an error: sets dev->dev_state to MEI_DEV_INIT_CLIENTS, calls mei_hbm_start_req(dev), etc.
>
> I am not sure if this is intentional and if this is related to the problem, but still.
>

Oh, looks like it is mei_hw_start() that first ignores the error. Might 
be a problem anyway.

Regards,
Eugene

-- 
Eugene Shatokhin, ROSA Laboratory.
www.rosalab.com
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.