linux-kernel - Re: [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppqfrw2t.fsf@nemi.mork.no>
Date:	Tue, 05 Nov 2013 11:18:02 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Julian Andres Klode <jak@...-linux.org>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	ibm-acpi-devel@...ts.sourceforge.net (open list:THINKPAD ACPI EXT...),
	platform-driver-x86@...r.kernel.org (open list:THINKPAD ACPI EXT...),
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds

Julian Andres Klode <jak@...-linux.org> writes:

>  
> +TPACPI_HANDLE(battery, root, "\\_SB.PCI0.LPC.EC.HKEY",
> +	   "\\_SB.PCI0.LPCB.EC.HKEY",		/* X121e, T430u */
> +	   "\\_SB.PCI0.LPCB.H_EC.HKEY",		/* L430 */
> +	   "\\_SB.PCI0.LPCB.EC0.HKEY",		/* Edge/S series */
> +	   );
> +

Isn't this just the full patch to the existing "hkey_handle" for those
models?  Why not just use that handle, like e.g the rfkill driver does?

Supported models could probably be autodetected by checking whether the
methods exist?

> +static struct attribute_group bat##_BAT##_attribute_group = { \
> +	.name  = "BAT" #_BAT, \
> +	.attrs = bat##_BAT##_attributes \
> +};

Are these names guaranteed to match the ACPI battery device(s)?

> +DEFINE_BATTERY(0);
> +DEFINE_BATTERY(1);

Are there always two batteries?



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/