linux-kernel - Re: [PATCH net-next V3 2/2] virtio-net: coalesce rx frags when possible during rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131104.200438.1658727667787717171.davem@davemloft.net>
Date:	Mon, 04 Nov 2013 20:04:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jasowang@...hat.com
Cc:	edumazet@...gle.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, rusty@...tcorp.com.au, mst@...hat.com,
	mwdalton@...gle.com, virtualization@...ts.linux-foundation.org,
	kmindg@...il.com
Subject: Re: [PATCH net-next V3 2/2] virtio-net: coalesce rx frags when
 possible during rx

From: Jason Wang <jasowang@...hat.com>
Date: Fri,  1 Nov 2013 14:07:48 +0800

> Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable
> rx buffers to page frag allocators) try to increase the payload/truesize for
> MTU-sized traffic. But this will introduce the extra overhead for GSO packets
> received because of the frag list. This commit tries to reduce this issue by
> coalesce the possible rx frags when possible during rx. Test result shows the
> about 15% improvement on full size GSO packet receiving (and even better than
> before commit 2613af0ed18a11d5c566a81f9a6510b73180660a).
...
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: Michael Dalton <mwdalton@...gle.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> ---
> Changes from V2:
> - call put_page() instead of depending on skb_coalesce_rx_frag()

Looks fantastic, applied, thanks Jason!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/