linux-kernel - Re: [PATCH v4 2/4] perf stat: add event unit and scale support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBQ1Kv9MMBhRdNoBA4k=n=cGVQtuUn810P7-PSu_SRwLug@mail.gmail.com>
Date:	Tue, 5 Nov 2013 14:34:45 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	Borislav Petkov <bp@...en8.de>,
	Maria Dimakopoulou <maria.n.dimakopoulou@...il.com>
Subject: Re: [PATCH v4 2/4] perf stat: add event unit and scale support

Hi,

One thing I realized while testing is that we cannot simply add the
unit printout like that.
This may break all the scripts people may have written to parse the
output of perf stat.
I think we need to make the display of the unit optional. If I do:
   $ perf stat -e cycles ls

The output should remain as it was before and not show:
$ perf stat -e cycles ls
      22782847475 ? cycles

So I think we need a --show-unit option. It would be off by default.
Of course doing this causes a mess with the current code because
of all the various printf() in builtin-stat.c but I think it is better for
the end user.

Any opinion?

On Mon, Nov 4, 2013 at 3:51 PM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Mon, Nov 04, 2013 at 03:47:53PM +0100, Stephane Eranian wrote:
>> Jiri,
>>
>>
>> Thanks for the patch. I tested it and it works fine.
>> I will merge it with my "unit and scale" and add
>> your Signed-off-by. Is that okay with you?
>
> sure, np
>
> jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/