linux-kernel - Re: [PATCH] staging: new asus fan driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131105151609.GA20950@kroah.com>
Date:	Tue, 5 Nov 2013 07:16:09 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [PATCH] staging: new asus fan driver

On Tue, Nov 05, 2013 at 08:29:40AM -0600, Felipe Contreras wrote:
> On Tue, Nov 5, 2013 at 6:52 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > On Tue, Nov 05, 2013 at 02:59:47AM -0600, Felipe Contreras wrote:
> >> Simple driver to enable control of the fan in ASUS laptops. So far this
> >> has only been tested in ASUS Zenbook Prime UX31A, but according to some
> >> online reference [1], it should work in other models as well.
> >>
> >> The implementation is very straight-forward, the only caveat is that the
> >> fan speed needs to be saved after it has been manually changed because
> >> it won't be reported properly until it goes back to 'auto' mode.
> >>
> >> [1] http://forum.notebookreview.com/asus/705656-fan-control-asus-prime-ux31-ux31a-ux32a-ux32vd.html
> >>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> >> ---
> >>
> >> Two incarnations of this code exists [1][2], one that used ACPI methods
> >> directly, and one through WMI. Unfortunately the WMI version needs us to pass
> >> physicall addresses which is not exactly clean, and that's the only reason the
> >> code is proposed for staging.
> >>
> >> Most likely this cannot graduate until acpica gets support to receive virtual
> >> addresses.
> >
> > When is that going to happen?
> 
> I don't know. Presumably when I get it done, which might be never, or
> a few days from now. Most likely it will take some time.

Then why not just merge this to the proper place, instead of relying on
staging?  I don't want to have to have a staging driver that is waiting
on external things to get it merged, instead of issues with the driver
itself, as you are now putting the burden of maintenance on me, for no
good reason other than you being too "lazy" to get other stuff done :)

So, I really don't want this driver, sorry, please merge it to the
"proper" place in the kernel itself, fixing up the ACPI core to do so,
or just living with the driver as-is if you don't want to do that
work...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/