linux-kernel - Re: linux-next: build failure after merge of the device-mapper tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52791B33.9060001@kernel.dk>
Date:	Tue, 05 Nov 2013 09:22:11 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Mike Snitzer <snitzer@...hat.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	Alasdair G Kergon <agk@...hat.com>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Kent Overstreet <kmo@...erainc.com>,
	Joe Thornber <ejt@...hat.com>
Subject: Re: linux-next: build failure after merge of the device-mapper tree

On 11/05/2013 05:54 AM, Mike Snitzer wrote:
> On Mon, Nov 04 2013 at 10:32pm -0500,
> Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> 
>> Hi Mike,
>>
>> On Mon, 4 Nov 2013 22:20:54 -0500 Mike Snitzer <snitzer@...hat.com> wrote:
>>>
>>> On Mon, Nov 04 2013 at  9:51pm -0500,
>>> Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>>>
>>>> After merging the device-mapper tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> drivers/md/dm-cache-target.c: In function 'bio_writes_complete_block':
>>>> drivers/md/dm-cache-target.c:1020:7: error: 'struct bio' has no member named 'bi_size'
>>>>    (bio->bi_size == (cache->sectors_per_block << SECTOR_SHIFT));
>>>>        ^
>>>>
>>>> Caused by commit 1bd270d800ec ("dm cache: promotion optimisation for
>>>> writes") interacting with commit ed2d2f9a8265 ("block: Abstract out bvec
>>>> iterator") from the block tree.
>>>>
>>>> I applied this fix up patch and can carry it as necessary:
>>>
>>> Yes that is needed, as is this (which begs the question: how should I be
>>
>> I will add that tomorrow.
>>
>>> handling the fact that post-merge changes are needed?  Especially since
>>> Linus will need the changes too):
>>
>> Who ever gets their tree in last has to tell Linus about these extra
>> merge fix ups as part of their pull request.
> 
> OK, that's what I thought, thanks for confirming.

Just a heads up that I plan on sending the block bits shortly, hopefully
merging sooner rather than later. This round is huge, so I'd like to get
it in asap.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/