linux-kernel - Re: [PATCH] pwm: samsung: memory leak bugfix in pwm_samsung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 Nov 2013 09:17:24 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Sangjung Woo <sangjung.woo@...sung.com>
Cc:	Thierry Reding <thierry.reding@...il.com>,
	linux-pwm@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tomasz Figa <t.figa@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>
Subject: Re: [PATCH] pwm: samsung: memory leak bugfix in pwm_samsung_free

Hi Sangjung,

On 5 November 2013 08:32, Sangjung Woo <sangjung.woo@...sung.com> wrote:
> There is certainly a kind of memory leak since allocated data (i.e.
> chip_data) is set NULL before freeing it by calling devm_kfree(). This
> patch fixes the memory leak bug by modifying its call order.
>
> Signed-off-by: Sangjung Woo <sangjung.woo@...sung.com>
> Reviewed-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
> ---
>  drivers/pwm/pwm-samsung.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index fcc8b9a..07b2d9d 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -224,8 +224,8 @@ static int pwm_samsung_request(struct pwm_chip *chip, struct pwm_device *pwm)
>
>  static void pwm_samsung_free(struct pwm_chip *chip, struct pwm_device *pwm)
>  {
> -       pwm_set_chip_data(pwm, NULL);
>         devm_kfree(chip->dev, pwm_get_chip_data(pwm));
> +       pwm_set_chip_data(pwm, NULL);
>  }

Similar patch has already been applied by Thierry.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/