linux-kernel - Re: [PATCH] ARM: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Nov 2013 09:47:43 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Duan Jiong <duanj.fnst@...fujitsu.com>
Cc:	kernel@...gutronix.de, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

On Wed, Nov 06, 2013 at 03:52:45PM +0800, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
> 
> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

> ---
>  arch/arm/mach-imx/mx31moboard-smartbot.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mx31moboard-smartbot.c b/arch/arm/mach-imx/mx31moboard-smartbot.c
> index 04ae45d..af6550e 100644
> --- a/arch/arm/mach-imx/mx31moboard-smartbot.c
> +++ b/arch/arm/mach-imx/mx31moboard-smartbot.c
> @@ -141,10 +141,7 @@ static int __init smartbot_otg_host_init(void)
>  		return -ENODEV;
>  
>  	pdev = imx31_add_mxc_ehci_otg(&otg_host_pdata);
> -	if (IS_ERR(pdev))
> -		return PTR_ERR(pdev);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(pdev);
>  }
>  #else
>  static inline int smartbot_otg_host_init(void) { return 0; }
> -- 
> 1.8.3.1
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/