linux-kernel - Re: [RESEND PATCH 2/2] staging/olpc_docn: reorder the lock sequence to avoid potential dead lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <527999DC.1090206@cn.fujitsu.com>
Date:	Wed, 06 Nov 2013 09:22:36 +0800
From:	Gu Zheng <guz.fnst@...fujitsu.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	jfrederich@...il.com, dsd@...top.org, jon.nettleton@...il.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, Tomi Valkeinen <tomi.valkeinen@...com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 2/2] staging/olpc_docn: reorder the lock sequence
 to avoid potential dead lock

Hi Dan,
On 11/05/2013 07:02 PM, Dan Carpenter wrote:

> On Tue, Nov 05, 2013 at 06:01:00PM +0800, Gu Zheng wrote:
>> The lock sequence of dcon_blank_fb(fb_info->lock ---> console_lock) is against
>> with the one of console_callback(console_lock ---> fb_info->lock), it'll
>> lead to a potential dead lock, so reorder the lock sequence of dcon_blank_fb
>> to avoid the potential dead lock.
>>
>> Signed-off-by: Gu Zheng <guz.fnst@...fujitsu.com>
> 
> Relax, Greg isn't taking new patches for another three weeks because the
> merge window is open.

Got it, I just want to gain some comments about this patch.

> 
> Also what happened to [PATCH 1/2]?

It fixes the similar issue of fb subsystem.
https://patchwork.kernel.org/patch/3140121/

Regards,
Gu

> 
> regards,
> dan carpenter
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/