linux-kernel - Re: [PATCH 0/3] makedumpfile: hugepage filtering for vmcore dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52799FC5.5040408@hp.com>
Date:	Wed, 06 Nov 2013 09:47:49 +0800
From:	Jingbai Ma <jingbai.ma@...com>
To:	Vivek Goyal <vgoyal@...hat.com>
CC:	Jingbai Ma <jingbai.ma@...com>, ptesarik@...e.cz,
	d.hatayama@...fujitsu.com, kumagai-atsushi@....nes.nec.co.jp,
	bhe@...hat.com, tom.vaden@...com, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, lisa.mitchell@...com,
	anderson@...hat.com, ebiederm@...ssion.com
Subject: Re: [PATCH 0/3] makedumpfile: hugepage filtering for vmcore dump

On 11/06/2013 04:26 AM, Vivek Goyal wrote:
> On Tue, Nov 05, 2013 at 09:45:32PM +0800, Jingbai Ma wrote:
>> This patch set intend to exclude unnecessary hugepages from vmcore dump file.
>>
>> This patch requires the kernel patch to export necessary data structures into
>> vmcore: "kexec: export hugepage data structure into vmcoreinfo"
>> http://lists.infradead.org/pipermail/kexec/2013-November/009997.html
>>
>> This patch introduce two new dump levels 32 and 64 to exclude all unused and
>> active hugepages. The level to exclude all unnecessary pages will be 127 now.
>
> Interesting. Why hugepages should be treated any differentely than normal
> pages?
>
> If user asked to filter out free page, then it should be filtered and
> it should not matter whether it is a huge page or not?

Yes, free hugepages should be filtered out with other free pages. It 
sounds reasonable.

But for active hugepages, I would offer user more choices/flexibility. 
(maybe bad).
I'm OK to filter active hugepages with other user data page.

Any other comments?


>
> Thanks
> Vivek


-- 
Thanks,
Jingbai Ma
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/