linux-kernel - Re: [PATCH] edac, highbank: remove dependency on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131106142025.GB16072@x1.alien8.de>
Date:	Wed, 6 Nov 2013 15:20:25 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Rob Herring <robherring2@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Rob Herring <rob.herring@...xeda.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org
Subject: Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

On Tue, Nov 05, 2013 at 09:25:52PM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@...xeda.com>
> 
> In order to enable on arm64 and improve the build coverage, remove the
> dependency on ARCH_HIGHBANK.
> 
> Signed-off-by: Rob Herring <rob.herring@...xeda.com>
> Cc: Doug Thompson <dougthompson@...ssion.com>
> Cc: Robert Richter <rric@...nel.org>
> Cc: linux-edac@...r.kernel.org
> ---
>  drivers/edac/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 878f090..fc8aaaf 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -328,14 +328,14 @@ config EDAC_TILE
>  
>  config EDAC_HIGHBANK_MC
>  	tristate "Highbank Memory Controller"
> -	depends on EDAC_MM_EDAC && ARCH_HIGHBANK
> +	depends on EDAC_MM_EDAC

Please, no, this'll get enabled on other arches where this driver is
simply N/A. It should only depend on the ARM arches it supports.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/