linux-kernel - Re: [PATCH] ths7303: Declare as static a private function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Nov 2013 15:33:25 +0100
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	"open list:MEDIA INPUT INFRA..." <linux-media@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ths7303: Declare as static a private function

Hi Ricardo,

Thank you for the patch.

On Wednesday 06 November 2013 15:27:48 Ricardo Ribalda Delgado wrote:
> git grep shows that the function is only called from ths7303.c
> 
> Fix this build warning:
> 
> CC      drivers/media/i2c/ths7303.o
> drivers/media/i2c/ths7303.c:86:5: warning: no previous prototype for 
> ‘ths7303_setval’ [-Wmissing-prototypes] int ths7303_setval(struct
> v4l2_subdev *sd, enum ths7303_filter_mode mode) ^
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>  drivers/media/i2c/ths7303.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c
> index 42276d9..16da153 100644
> --- a/drivers/media/i2c/ths7303.c
> +++ b/drivers/media/i2c/ths7303.c
> @@ -83,7 +83,8 @@ static int ths7303_write(struct v4l2_subdev *sd, u8 reg,
> u8 val) }
> 
>  /* following function is used to set ths7303 */
> -int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode)
> +static int ths7303_setval(struct v4l2_subdev *sd,
> +					enum ths7303_filter_mode mode)

If you align 'enum' on 'struct' from the line above,

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  {
>  	struct i2c_client *client = v4l2_get_subdevdata(sd);
>  	struct ths7303_state *state = to_state(sd);
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/