linux-kernel - Re: [PATCH] edac, highbank: remove dependency on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131106165437.GA21870@x1.alien8.de>
Date:	Wed, 6 Nov 2013 17:54:38 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Rob Herring <robherring2@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Rob Herring <rob.herring@...xeda.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org
Subject: Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

On Wed, Nov 06, 2013 at 10:15:04AM -0600, Rob Herring wrote:
> Other maintainers disagree because it reduces build coverage.

What possible build coverage are we talking about when building highbank
on x86, for example? And what does a build failure in that configuration
tell you if it builds and boots fine on your hardware?

> Having done some cross arch clean-up, I have to agree with that
> position. Iterating builds over different arches is bad enough, but
> iterating over all configs for each arch is a pain.

So make highbank depend only on the arches for which it is supposed to
work but not for *all* arches. Look at how the other edac drivers do it,
x86 ones depend on X86, tile on tile, etc, etc. Why should highbank be
special?

> It would be nice to have a uniform policy here.

Simple: drivers should be selectable/buildable only on the arches
they're supposed to run on.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/