linux-kernel - Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383760556.7940.28.camel@joe-AO722>
Date:	Wed, 06 Nov 2013 09:55:56 -0800
From:	Joe Perches <joe@...ches.com>
To:	Eugene Krasnikov <k.eugene.e@...il.com>,
	"Luis R. Rodriguez" <mcgrof@....qualcomm.com>
Cc:	"John W. Linville" <linville@...driver.com>,
	wcn36xx <wcn36xx@...ts.infradead.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	ath5k-devel@...ts.ath5k.org,
	ath9k-devel <ath9k-devel@...ts.ath9k.org>,
	ath10k@...ts.infradead.org
Subject: Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

On Wed, 2013-11-06 at 07:49 +0000, Eugene Krasnikov wrote:
> Hm... when it comes to semicolon the patch seems to be good. When it
> comes to dynamic debugging i think we should have a separate
> discussion about that.
> I personally like the whole idea about dynamic debug but if you want
> to change it i would suggest to have some kind of framework for all
> ath drivers(or maybe all wireless drivers). Because obviously you can
> find common code in every driver that defines it's own debug
> functions/debug levels and so on. Why not to make a framework with
> standard API/levels?

You need to bring that up with the Atheros folk.
I've tried.  The view seemed to be it was more
trouble than it was worth.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/