linux-kernel - Re: [PATCH] drm: Add the mutex protection in drm_do_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPM=9tw4MbFDDKyuEZS2i2sh07cGgzM6GdeK_UkEiuXW9v7U-A@mail.gmail.com>
Date:	Wed, 6 Nov 2013 13:33:13 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Jun Chen <jun.d.chen@...el.com>
Cc:	Dave Airlie <airlied@...ux.ie>, Al Viro <viro@...iv.linux.org.uk>,
	Dave Airlie <airlied@...hat.com>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: Add the mutex protection in drm_do_vm_fault.

On Sat, Oct 12, 2013 at 1:47 AM, Jun Chen <jun.d.chen@...el.com> wrote:
>
> There are no mutex protection for the dev->map_hash while calling
> the drm_ht_find_item in the function drm_do_vm_fault. So try to
> mutex firstly and then find the list for using to avoid this race
> condition.

Can I ask how or why you found this? from what I can see we really
shouldn't be executing this code on modern drivers.

this is the sort of thing I'd really like to have tested on real hw,
which means someone booting it on AGP using UMS drivers I think.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/