[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <527AD5A2.70902@intel.com>
Date: Wed, 06 Nov 2013 15:49:54 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Andrew Morton <akpm@...ux-foundation.org>,
Jerome Marchand <jmarchan@...hat.com>
CC: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
On 11/06/2013 02:33 PM, Andrew Morton wrote:
> On Wed, 6 Nov 2013 03:42:20 -0500 (EST) Jerome Marchand <jmarchan@...hat.com> wrote:
>> That was my first version of this patch (actually "kbytes" to avoid
>> overflow).
>> Dave raised the issue that it silently breaks the user interface:
>> overcommit_ratio is zero while the system behaves differently.
>
> I don't understand that at all. We keep overcommit_ratio as-is, with
> the same default values and add a different way of altering it. That
> should be back-compatible?
Reading the old thread, I think my main point was that we shouldn't
output overcommit_ratio=0 when overcommit_bytes>0. We need to round up
for numbers less than 1 so that folks don't think overcommit_ratio is _off_.
I was really just trying to talk you in to cramming the extra precision
in to the _existing_ sysctl. :) I don't think bytes vs. ratio is really
that big of a deal.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists