linux-kernel - Re: [PATCH] thermal: Fix binding problem when there is thermal zone params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5279DBD6.9090708@nvidia.com>
Date:	Wed, 6 Nov 2013 14:04:06 +0800
From:	Wei Ni <wni@...dia.com>
To:	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <eduardo.valentin@...com>
CC:	"durgadoss.r@...el.com" <durgadoss.r@...el.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Jinyoung Park <jinyoungp@...dia.com>
Subject: Re: [PATCH] thermal: Fix binding problem when there is thermal zone
 params

On 11/06/2013 01:29 PM, Zhang Rui wrote:
> On Fri, 2013-10-18 at 18:03 +0800, Wei Ni wrote:
>> @@ -247,7 +247,7 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
>>  		if (!pos->tzp && !pos->ops->bind)
>>  			continue;
>>  
>> -		if (!pos->tzp && pos->ops->bind) {
>> +		if (pos->ops->bind) {
>>  			ret = pos->ops->bind(pos, cdev);
>>  			if (ret)
>>  				print_bind_err_msg(pos, cdev, ret);
> IMO, we should also add
> +		continue;
> after binding with pos->ops->bind(), to void binding via pos->tzp->tbp
> again, no?

Oh, yes, you are right. I will add it.

> 
> thanks,
> rui
>> @@ -282,8 +282,8 @@ static void bind_tz(struct thermal_zone_device *tz)
>>  
>>  	mutex_lock(&thermal_list_lock);
>>  
>> -	/* If there is no platform data, try to use ops->bind */
>> -	if (!tzp && tz->ops->bind) {
>> +	/* If there is ops->bind, try to use ops->bind */
>> +	if (tz->ops->bind) {
>>  		list_for_each_entry(pos, &thermal_cdev_list, node) {
>>  			ret = tz->ops->bind(tz, pos);
>>  			if (ret)
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/