linux-kernel - Re: [trivial PATCH] module.h: Remove unnecessary semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Nov 2013 21:09:51 -0800
From:	Joe Perches <joe@...ches.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [trivial PATCH] module.h: Remove unnecessary semicolon

On Thu, 2013-11-07 at 12:32 +1030, Rusty Russell wrote:
> Joe Perches <joe@...ches.com> writes:
> > This semicolon isn't necessary, remove it.
> >
> > Signed-off-by: Joe Perches <joe@...ches.com>
> 
> This is a terrible description.  Really bad.

I'd've preferred no description.

> First, it just repeats the subject, with more words.

Which others have demanded.

> Second, it gives me no indication that you've done a grep to make sure
> noone is abusing the macro, so I can't apply it without doing that check
> myself.

That's a trust issue.
I've done it.  It isn't necessary.
The other #define module_put_and_exit in a
different #if #else already doesn't have one.

Trust it or not, apply it or not.

> Please try again.

No thanks.

cheers, Joe

> > diff --git a/include/linux/module.h b/include/linux/module.h
[]
> > @@ -454,7 +454,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *,
> >  
> >  extern void __module_put_and_exit(struct module *mod, long code)
> >  	__attribute__((noreturn));
> > -#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code);
> > +#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code)
> >  
> >  #ifdef CONFIG_MODULE_UNLOAD
> >  unsigned long module_refcount(struct module *mod);

$ git grep -w module_put_and_exit
crypto/algboss.c:       module_put_and_exit(0);
crypto/algboss.c:       module_put_and_exit(0);
fs/cifs/connect.c:      module_put_and_exit(0);
fs/nfs/nfs4state.c:     module_put_and_exit(0);
fs/nfsd/nfssvc.c:       module_put_and_exit(0);
include/linux/module.h:#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code);
include/linux/module.h:#define module_put_and_exit(code) do_exit(code)
net/bluetooth/bnep/core.c:      module_put_and_exit(0);
net/bluetooth/cmtp/core.c:      module_put_and_exit(0);
net/bluetooth/hidp/core.c:      module_put_and_exit(0);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/